feat(MenuItem): allow observing submenu content resize when a re-render isn't triggered #2713
Conversation
|
A new prerelease version of this PR has been published! 🎉 To update Or with npm: To update Or with npm: |
| /** | ||
| * Enables the observation of content resize for the menu item's submenu. | ||
| * When set to `true`, a ResizeObserver is attached to the popper content, | ||
| * automatically triggering repositioning when the size of the submenu's content changes. | ||
| * | ||
| * This is useful for when submenu's content may grow or shrink without a re-render being triggered. | ||
| */ | ||
| observeSubMenuContentResize?: boolean; |
There was a problem hiding this comment.
Are the implementation details really matter here? I think we can simplify it and just say that it will respond to resizing of the content
Also worth renaming prop name IMO, maybe autoAdjustSubMenuOnResize?
There was a problem hiding this comment.
autoAdjustOnSubMenuContentResize?
|
A new prerelease version of this PR has been published! 🎉 To update Or with npm: To update Or with npm: |
YossiSaadi
deleted the
feat/yossi/menu-allow-updating-position-of-submenu-even-if-re-render-not-8222833258
branch
https://monday.monday.com/boards/3532714909/pulses/8222833258
Before:
After:
